Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): fix unreachable @opentelemetry/api/experimental entry #4446

Merged
merged 4 commits into from
Jan 31, 2024
Merged

fix(api): fix unreachable @opentelemetry/api/experimental entry #4446

merged 4 commits into from
Jan 31, 2024

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

@opentelemetry/api/experimental is not reachable for missing files.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Integration test with a separate package verifying the @opentelemetry/api package can be properly imported

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@legendecas legendecas requested a review from a team January 30, 2024 07:51
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

Merging #4446 (09d8767) into main (c98a5d3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4446   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         331      331           
  Lines        9518     9518           
  Branches     2022     2022           
=======================================
  Hits         8793     8793           
  Misses        725      725

@legendecas legendecas force-pushed the integration/api branch 2 times, most recently from c279da9 to 0853854 Compare January 30, 2024 07:56
pichlermarc
pichlermarc approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 👍
I like the idea of having some integration tests to test things like that.

@legendecas legendecas merged commit ac75b70 into open-telemetry:main Jan 31, 2024
20 checks passed
@legendecas legendecas deleted the integration/api branch January 31, 2024 03:58
@pichlermarc pichlermarc mentioned this pull request Feb 23, 2024
Merged
This was referenced May 22, 2024
Open
Open
@integraci-co804 integraci-co804 mentioned this pull request May 28, 2024
Open
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
@legendecas @Zirak
fix(api): fix unreachable @opentelemetry/api/experimental entry (open…
93403a5 
…-telemetry#4446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees
No one assigned
Labels
pkg:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendecas @Flarna @pichlermarc