Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shim-opentracing): replace deprecated spanAttributes #4430

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Update minimum API version to 1.1.0 in opentelemetry-shim-opentracing
  • Replace deprecated SpanAttributes and SpanAttributeValue with Attributes and AttributeValue respectively

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit tests pass

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been updated

@JamieDanielson JamieDanielson self-assigned this Jan 18, 2024
@JamieDanielson JamieDanielson marked this pull request as ready for review January 18, 2024 22:11
@JamieDanielson JamieDanielson requested a review from a team January 18, 2024 22:11
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #4430 (ff457cf) into next (543f0b4) will increase coverage by 0.01%.
Report is 6 commits behind head on next.
The diff coverage is 96.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4430      +/-   ##
==========================================
+ Coverage   92.24%   92.26%   +0.01%     
==========================================
  Files         332      332              
  Lines        9437     9434       -3     
  Branches     1999     1995       -4     
==========================================
- Hits         8705     8704       -1     
+ Misses        732      730       -2     
Files Coverage Δ
...erimental/packages/api-logs/src/types/LogRecord.ts 100.00% <ø> (ø)
...porter-metrics-otlp-grpc/src/OTLPMetricExporter.ts 93.75% <100.00%> (+0.20%) ⬆️
...-otlp-http/src/platform/node/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...orter-metrics-otlp-proto/src/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts 94.75% <100.00%> (+0.83%) ⬆️
...ackages/otlp-exporter-base/src/OTLPExporterBase.ts 95.23% <100.00%> (ø)
...mental/packages/otlp-transformer/src/logs/index.ts 100.00% <ø> (ø)
experimental/packages/sdk-logs/src/LogRecord.ts 98.05% <100.00%> (+0.07%) ⬆️
...ckages/opentelemetry-core/src/common/attributes.ts 93.18% <100.00%> (ø)
...metry-core/src/trace/sampler/ParentBasedSampler.ts 83.87% <ø> (ø)
... and 3 more

... and 2 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 9727686 into open-telemetry:next Jan 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants