-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-undici): add undici
and fetch
instrumentations
#4393
feat(instrumentation-undici): add undici
and fetch
instrumentations
#4393
Conversation
1st discussion point
IMHO I think we should have the configuration that applies to |
about 3rd point
I think it could be misleading if a customer is using |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4393 +/- ##
==========================================
- Coverage 92.22% 90.36% -1.87%
==========================================
Files 333 163 -170
Lines 9459 3799 -5660
Branches 2009 845 -1164
==========================================
- Hits 8724 3433 -5291
+ Misses 735 366 -369 |
@david-luna Seems like you have done a lot of work so far! I've just started using OpenTelemetry (which is awesome) and stumbled upon this issue in our project: #4247. I'd be happy to help test the new instrumentations whenever you need help. |
There was a discussion in latest OTel JS SIG abut the location of this package (https://docs.google.com/document/d/1tCyoQK49WVcE-x8oryZOTTToFm7sIeUhxFPm9g-qL1k/edit#heading=h.ry29ajruzxyg)). The conclusion was to move it to https://github.com/open-telemetry/opentelemetry-js-contrib |
Which problem is this PR solving?
This PR adds a new instrumentation that subscribes to the diagnostic channels used by
undici
pacakge. The instrumentation will get traces from:undici
packagefetch
API since this is implemented usingundici
internally and publishes the same messages on the same diagnostic channels.Code was donated by @djMax from https://github.com/gas-buddy/service/blob/main/src/telemetry/fetchInstrumentation.ts
NOTE: the PR is marked as draft since there are some todos (to be discussed in comments)
HttpInstrumentation
differentiate between a req made withdecided it's not necessary (HTTP instrumentation doesn't for http livs like axios, got,...)fetch
or usingundici
explicitly?Fixes #4333
Short description of the changes
undici
Type of change
How Has This Been Tested?
By unit tests.
Checklist: