feat(metrics): add registerMetric and getMetrics #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
danielkhan,
iredelmeier,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
mayurkale22
changed the title
mayurkale22
commented
Oct 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 94.83% 95.09% +0.25%
==========================================
Files 131 132 +1
Lines 6528 6851 +323
Branches 560 572 +12
==========================================
+ Hits 6191 6515 +324
+ Misses 337 336 -1
|
mayurkale22
force-pushed
the
registerMetric
branch
from
0361ac1 to
dde4d20
Compare
mayurkale22
force-pushed
the
registerMetric
branch
2 times, most recently
from
9bef4bf to
782162e
Compare
danielkhan
approved these changes
Oct 24, 2019
mayurkale22
force-pushed
the
registerMetric
branch
from
782162e to
bc0fcda
Compare
What do you think about this TODO -> https://github.com/open-telemetry/opentelemetry-js/pull/437/files#r336268261 |
mayurkale22
force-pushed
the
registerMetric
branch
from
bc0fcda to
18804bf
Compare
danielkhan
approved these changes
Oct 28, 2019
mayurkale22
force-pushed
the
registerMetric
branch
from
18804bf to
f8e3fe1
Compare
|
It looks like |
Yes, this is intentional. |
dyladan
approved these changes
Oct 31, 2019
markwolff
approved these changes
Oct 31, 2019
bg451
approved these changes
Oct 31, 2019
mayurkale22
force-pushed
the
registerMetric
branch
from
f1445ec to
d7c09fc
Compare
OlivierAlbertini
approved these changes
Oct 31, 2019
dyladan
reviewed
Nov 1, 2019
mayurkale22
force-pushed
the
registerMetric
branch
from
00115df to
0ec801a
Compare
dyladan
reviewed
Nov 1, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Gerhard Stöbich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates Implement Metrics SDK #402
Continuation of Metrics SDK feat: implement metrics sdk #415.
Added methods (
registerMetricandgetMetrics) to collect recorded values in the format of ReadableMetric, which can be used by metric exporters to transform and send to the backend.Pending stuff for next PRs:
meter.getMetrics()MeasureHandle.TODO:
Decide whichMetricDescriptorTypeto assign in case of Gauge (two options areMetricDescriptorType.GAUGE_INT64andMetricDescriptorType.GAUGE_DOUBLE) and in case of counter (two options areMetricDescriptorType.COUNTER_INT64andMetricDescriptorType.COUNTER_DOUBLE)(update 1: 10/30)
Implemented option 3 as per SIG discussion: https://docs.google.com/document/d/1g0O7TZ4KH82iwbJmEdBh3qWONnHbap3ajjD2_HWA0mY/edit
/cc @danielkhan @bg451