Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release API 1.7.0/Core 1.18.0/Experimental 0.45.0 #4254

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Nov 6, 2023

API 1.7.0

🚀 (Enhancement)

Core 1.18.0

🚀 (Enhancement)

🐛 (Bug Fix)

🏠 (Internal)

  • chore: track package-lock.json #4238 @legendecas
    • Switched to npm workspaces to bootstrap dependencies.

Experimental 0.45.0

💥 Breaking Change

  • fix(sdk-node)!: remove the explicit dependency on @opentelemetry/exporter-jaeger that was kept on the previous release
    • '@opentelemetry/exporter-jaeger' is no longer be a dependency of this package. To continue using '@opentelemetry/exporter-jaeger', please install it manually.
      • NOTE: @opentelemetry/exporter-jaeger is deprecated, consider switching to one of the alternatives described here
  • fix(otlp-transformer)!: OTLP json encoding #4220 @seemk
    • Fixes a bug in the OTLP (http/json) exporters where timestamps were not encoded as strings, causing the export to
      be rejected by OTLP endpoints

@pichlermarc pichlermarc requested a review from a team November 6, 2023 16:14
@pichlermarc pichlermarc changed the title release: API 1.7.0/Core 1.18.0/Experimental 0.45.0 chore: release API 1.7.0/Core 1.18.0/Experimental 0.45.0 Nov 6, 2023
@pichlermarc pichlermarc force-pushed the release/api-1.7.0-core-1.18.0-experimental-0.45.0 branch from 2aafd3a to 0629ca5 Compare November 6, 2023 16:17
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #4254 (44c3e1e) into main (9fd1948) will not change coverage.
The diff coverage is n/a.

❗ Current head 44c3e1e differs from pull request most recent head 771f4b1. Consider uploading reports for the commit 771f4b1 to get more accurate results

@@           Coverage Diff           @@
##             main    #4254   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         330      330           
  Lines        9417     9417           
  Branches     1993     1993           
=======================================
  Hits         8693     8693           
  Misses        724      724           

Copy link

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fryuni
Copy link

Fryuni commented Nov 7, 2023

Why a minor bump on the experimental packages if there were only fixes and internal changes?

By semver before v1 the minor should be for breaking changes and there was none, right?

@Flarna
Copy link
Member

Flarna commented Nov 7, 2023

Why a minor bump on the experimental packages if there were only fixes and internal changes?

Isn't the fix for the breaking change in JSON export actually again a breaking change? So I think a minor bump is correct.
One could argue that release notes should reflect this.

@pichlermarc
Copy link
Member Author

pichlermarc commented Nov 7, 2023

Why a minor bump on the experimental packages if there were only fixes and internal changes?

By semver before v1 the minor should be for breaking changes and there was none, right?

@opentelemetry/sdk-node has a breaking change that requires users to manually install the @opentelemetry/exporter-jaeger package if they want to use it. While @opentelemetry/otlp-transformer is not intended for public consumption, I'd still agree with Flarna that this change itself was breaking (modified the signature for createExportLogsServiceRequest in a breaking way), and therefore bumping minor is appropriate.

Edit: adapted the changelog to reflect that.

@pichlermarc pichlermarc merged commit 73b4466 into open-telemetry:main Nov 7, 2023
17 checks passed
@pichlermarc pichlermarc deleted the release/api-1.7.0-core-1.18.0-experimental-0.45.0 branch November 7, 2023 10:25
dyladan added a commit that referenced this pull request Nov 15, 2023
* chore: track package-lock.json (#4238)

* chore: track package-lock.json

* Pin to old versions for node 14

* Use version range

* Remove unused cached directories

* Temporarily disable other tests

* Temporarily enable only api test

* Enable only some packages

* Test only api packages

* Test trace exporters

* Fix line ordering

* Test all packages except otlp exporters

* Add trace http exporter

* Add trace proto exporter

* Test all but grpc exporters

* chore: use npm workspaces and degrade lerna to v6

* chore: get rid of lerna bootstrap

* chore: use npx

* chore: allow install scripts to setup buf

* chore: fix w3c-integration-test cache key

* chore: fix cache key

* chore: disable resource compat test

* chore: fix node_modules assumptions

* chore: fix hoisted karma issue

* chore: fix markdown linter complaints

* chore: lock @grpc/grpc-js to v1.8.21

* Break caches

* chore: remove cache

* chore: fixup inline commands

---------

Co-authored-by: Daniel Dyla <[email protected]>

* docs: fixed link to benchmark results (#4233)

Co-authored-by: Chengzhong Wu <[email protected]>

* chore(deps): update all patch versions (#4215)

* fix: otlp json encoding (#4220)

Co-authored-by: Marc Pichler <[email protected]>

* fix: remove duplicate export star from version.ts (#4225)

Co-authored-by: Marc Pichler <[email protected]>

* docs: fix sdk-node config instructions (#4249)

Co-authored-by: Marc Pichler <[email protected]>

* feat(api): publish api esnext target (#4231)

* chore: release API 1.7.0/Core 1.18.0/Experimental 0.45.0 (#4254)

* fix(sdk-metrics): hand-roll MetricAdvice type as older API versions do not include it (#4260)

* chore: prepare release 1.18.1/0.45.1 (#4261)

* chore: no need for 'packages' in "lerna.json" (#4264)

* Benchmark tests for trace OTLP transform and BatchSpanProcessor (#4218)

Co-authored-by: Marc Pichler <[email protected]>

* chore: type reference on zone.js (#4257)

Co-authored-by: Marc Pichler <[email protected]>

* docs: add docker-compose to run prometheus for the experimental example (#4268)

Co-authored-by: Marc Pichler <[email protected]>

* fix(sdk-logs): avoid map attribute set when count limit exceeded (#4195)

Co-authored-by: Marc Pichler <[email protected]>

* chore(deps): update dependency chromedriver to v119 [security] (#4280)

* chore(deps): update actions/setup-node action to v4 (#4236)

* fix(sdk-trace-base): processor onStart called with a span having empty attributes (#4277)

Co-authored-by: artahmetaj <[email protected]>

* Update fetch instrumentation to be runtime agnostic (#4063)

Co-authored-by: Marc Pichler <[email protected]>

---------

Co-authored-by: Chengzhong Wu <[email protected]>
Co-authored-by: Martin Kuba <[email protected]>
Co-authored-by: Mend Renovate <[email protected]>
Co-authored-by: Siim Kallas <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: David Luna <[email protected]>
Co-authored-by: Dinko Osrecki <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: François <[email protected]>
Co-authored-by: Hyun Oh <[email protected]>
Co-authored-by: André Cruz <[email protected]>
Co-authored-by: artahmetaj <[email protected]>
Co-authored-by: drewcorlin1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants