Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter-metrics-otlp-proto): add esm build #4099

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Looks like we didn't build esm and esnext for @opentelemetry/exporter-metrics-otlp-proto. This PR adds a build for it.

Fixes #4097

Type of change

  • New feature (non-breaking change which adds functionality)

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4099 (0e13d67) into main (ed27a37) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e13d67 differs from pull request most recent head 938f6d2. Consider uploading reports for the commit 938f6d2 to get more accurate results

@@           Coverage Diff           @@
##             main    #4099   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files         294      294           
  Lines        8264     8264           
  Branches     1714     1714           
=======================================
  Hits         7655     7655           
  Misses        609      609           

@pichlermarc pichlermarc marked this pull request as ready for review August 30, 2023 14:05
@pichlermarc pichlermarc requested a review from a team August 30, 2023 14:05
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but we should reconsider our esm publishing strategy anyway since these esm versions aren't used by node esm

@pichlermarc pichlermarc merged commit be16272 into open-telemetry:main Sep 18, 2023
16 checks passed
@pichlermarc pichlermarc deleted the feat/proto-metrics-add-esm branch September 18, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter-metrics-otlp-proto] Add ESM support
2 participants