fix: Replace require with import

[ddeboer]

Which problem is this PR solving?

Modernise by replacing require with import.

This may also solve the following error when running tests that execute instrumented code
that has at least one exporter configured:

ReferenceError: You are trying to `import` a file after the Jest environment has been torn down.

Short description of the changes

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ddeboer / name: David de Boer (30b2c5c)

[dyladan]

This is done intentionally. The util is lazy loaded after application start because it requires the http module. If we require the http module, we then can't instrument it later. I believe we should be able to now for traces because of the proxy tracer which has been added to address this issue, but there still is no solution for that in metrics or logs. @pichlermarc you're more familiar with the exporters than me. Am I missing anything here?

[codecov]

Codecov Report

Merging #4015 (207f991) into main (0f20b2a) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 207f991 differs from pull request most recent head 30b2c5c. Consider uploading reports for the commit 30b2c5c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4015      +/-   ##
==========================================
+ Coverage   92.30%   92.31%   +0.01%     
==========================================
  Files         321      321              
  Lines        9189     9189              
  Branches     1953     1953              
==========================================
+ Hits         8482     8483       +1     
+ Misses        707      706       -1     

see 1 file with indirect coverage changes

[Flarna]

The ProxyTracerProvider doesn't solve the instrument after load problem. It solves the get tracer before TracerProvider was registered problem.

Not sure about the plans to publish an ESM module but if this is planned I guess this should be likely a dynamic import or so. But not sure if ESM and CJS can be in a single file for such cases.

[pichlermarc]

This is done intentionally. The util is lazy loaded after application start because it requires the http module. If we require the http module, we then can't instrument it later. I believe we should be able to now for traces because of the proxy tracer which has been added to address this issue, but there still is no solution for that in metrics or logs. @pichlermarc you're more familiar with the exporters than me. Am I missing anything here?

The ProxyTracerProvider doesn't solve the instrument after load problem. It solves the get tracer before TracerProvider was registered problem.

exactly this. What it is trying to do is to defer requiring anything before instrumentations can wrap it, so the ProxyTracerProvider does not help in this case, unfortunately.

Not sure about the plans to publish an ESM module but if this is planned I guess this should be likely a dynamic import or so. But not sure if ESM and CJS can be in a single file for such cases.

Yep, I think we'll need to take care of this using multiple files. ESM publishing was already added in #3208 if I recall correctly.

[dyladan]

This is done intentionally. The util is lazy loaded after application start because it requires the http module. If we require the http module, we then can't instrument it later. I believe we should be able to now for traces because of the proxy tracer which has been added to address this issue, but there still is no solution for that in metrics or logs. @pichlermarc you're more familiar with the exporters than me. Am I missing anything here?

The ProxyTracerProvider doesn't solve the instrument after load problem. It solves the get tracer before TracerProvider was registered problem.

exactly this. What it is trying to do is to defer requiring anything before instrumentations can wrap it, so the ProxyTracerProvider does not help in this case, unfortunately.

Bah yeah sorry.

Not sure about the plans to publish an ESM module but if this is planned I guess this should be likely a dynamic import or so. But not sure if ESM and CJS can be in a single file for such cases.

Yep, I think we'll need to take care of this using multiple files. ESM publishing was already added in #3208 if I recall correctly.

Our ESM publishing only works for bundlers which find the build/esm directory. Node will require us to rethink our distribution strategy. Now that ESM support is widespread I think it is well past time to do so.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions]

This PR was closed because it has been stale for 14 days with no activity.