-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk-metrics): ignore invalid metric values #3988
fix(sdk-metrics): ignore invalid metric values #3988
Conversation
b18e4ca
to
fc10848
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3988 +/- ##
==========================================
+ Coverage 92.34% 92.36% +0.02%
==========================================
Files 321 321
Lines 9249 9264 +15
Branches 1962 1968 +6
==========================================
+ Hits 8541 8557 +16
+ Misses 708 707 -1
|
fc10848
to
85d6a01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to have this fixed. Thank you for taking care of this. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry on the delay, just needs a changelog conflict resolved 👍
looks like the node 8 backtests are failing for some reason but I can't see what that reason is. The tests have |
Looks like it's now failing on other PRs (and main as well). Some dependency must have changed. |
@dyladan @martinkuba looks a dependency in |
Which problem is this PR solving?
Ignore invalid metric values.
Fixes #3985
Type of change
How Has This Been Tested?
Checklist: