fix(parseKeyPairsIntoRecord): allow equals in baggage value #3974

[krosenk729]

proposed fix for parseKeyPairsIntoRecord issue 3974

Which problem is this PR solving?

Baggage header values can contain equals as part of their value. parseKeyPairsIntoRecord was treating every = as a delimeter

Fixes #3974

Short description of the changes

This will allow parseKeyPairsIntoRecord('key=something==') to return parsed header values

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• parseKeyPairsIntoRecord('key1=something==')
• parseKeyPairsIntoRecord('key1=something==,key2=somethingelse')

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: krosenk729 / name: Katherine (f8870b5, 90cd2bd, e223fff, 8b9e05a)
• ✅ login: pichlermarc / name: Marc Pichler (a93182c, 596d4ee)

[pichlermarc]

Hi @krosenk729, thank you for your contribution. It looks like there are still some tests that are failing. Looking a bit into it, it looks like some tests that already existed are now outdated (double equal is given as an invalid example, when it is in fact valid). Feel free to adapt those 🙂

[krosenk729]

thank you so much for taking a look @pichlermarc ... I (hopefully) fixed that so the changes are good.

I also see github saying the branch is out of sync with main, and I'm not sure what your convention is with that. just let me know if I need to do a back-merge or anything. thanks

[codecov]

Codecov Report

Merging #3975 (25308b0) into main (3732256) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 25308b0 differs from pull request most recent head 596d4ee. Consider uploading reports for the commit 596d4ee to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3975   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         321      321           
  Lines        9264     9264           
  Branches     1968     1968           
=======================================
  Hits         8558     8558           
  Misses        706      706           

Files Changed	Coverage Δ
packages/opentelemetry-core/src/baggage/utils.ts	75.00% <100.00%> (ø)

[pichlermarc]

Hi @krosenk729, please also add a changelog entry in CHANGELOG.md (you can just follow the same format there), then we can get this merged. 🙂

cc @dyladan I know you've done some work on the baggage spec, would you mind also taking a look at this PR? 🙂

[krosenk729]

@pichlermarc thanks! updated!

[krosenk729]

hey @pichlermarc anything else I need to do for this one? thanks

[pichlermarc]

@krosenk729, no nothing to do anymore. thanks! 🙂
Let's get that into the next release. 🙂