Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start time bug in cumulative ExponentialHistogram #3930

Closed
wants to merge 1 commit into from

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Jun 20, 2023

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Short description of the changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #3930 (ed49546) into main (19fb033) will decrease coverage by 1.74%.
The diff coverage is n/a.

❗ Current head ed49546 differs from pull request most recent head 45a0db4. Consider uploading reports for the commit 45a0db4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3930      +/-   ##
==========================================
- Coverage   92.90%   91.16%   -1.74%     
==========================================
  Files         297       82     -215     
  Lines        8838     1800    -7038     
  Branches     1815      363    -1452     
==========================================
- Hits         8211     1641    -6570     
+ Misses        627      159     -468     

see 221 files with indirect coverage changes

@pichlermarc
Copy link
Member

Fixed by #3934 🙂

@pichlermarc pichlermarc closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants