-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instrumentation-grpc): add 'grpc' deprecation notice postinstall script #3833
chore(instrumentation-grpc): add 'grpc' deprecation notice postinstall script #3833
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3833 +/- ##
==========================================
- Coverage 92.95% 91.73% -1.23%
==========================================
Files 297 169 -128
Lines 9060 4672 -4388
Branches 1848 927 -921
==========================================
- Hits 8422 4286 -4136
+ Misses 638 386 -252 |
experimental/packages/opentelemetry-instrumentation-grpc/package.json
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-grpc/package.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Dyla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a non-blocking suggestion for adding color to make it pop more, otherwise looks good to me.
experimental/packages/opentelemetry-instrumentation-grpc/package.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which problem is this PR solving?
We currently have no proper way to notify users that the 'grpc' package instrumentation code is being removed from the
@opentelemetry/instrumentation-grpc
package. As discussed in the SIG meeting last week, since the package is not released as stable yet, increasing semver major is not an option.Please feel free to suggest any changes to wording of the changelog/message.
Related #3780, #3807
Type of change
How Has This Been Tested?
postinstall
script locallyChecklist: