-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exporter-logs-otlp-http): implements otlp-http exporter for logs #3764
feat(exporter-logs-otlp-http): implements otlp-http exporter for logs #3764
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3764 +/- ##
==========================================
- Coverage 92.96% 92.95% -0.01%
==========================================
Files 295 297 +2
Lines 9036 9060 +24
Branches 1841 1848 +7
==========================================
+ Hits 8400 8422 +22
- Misses 636 638 +2
|
e32321b
to
4866424
Compare
@dyladan @pichlermarc @martinkuba cc. |
Nevermind I just read the context in the other PR |
@dyladan replace. I have contacted another contributor in #3755, and he/she will also make further contributions based on this PR. (Mainly considering that the development has actually been completed before, so there is no need to repeat it. #3755 also seems to have not been fully developed yet. |
experimental/packages/exporter-logs-otlp-http/src/platform/node/OTLPLogExporter.ts
Outdated
Show resolved
Hide resolved
Many failing CI steps |
fixed, cc~ |
e3db123
to
b698789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 🙂
Just a few docs nits 🙂
@dyladan take a look and see if can merge ? |
Reached out to Dan - Martin & my reviews should be sufficient. 🙂 |
Which problem is this PR solving?
Short description of the changes
Implements otlp-http exporter for logs, support web and node. The implementation of Logs has been mentioned in #3442 before, but due to the large amount of code, it was split into SDK and Exporter parts. This is the implementation of the Exporter part.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: