Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter-logs-otlp-http): implements otlp-http exporter for logs #3764

Merged
merged 10 commits into from
May 25, 2023

Conversation

fuaiyi
Copy link
Contributor

@fuaiyi fuaiyi commented Apr 26, 2023

Which problem is this PR solving?

  • exporter-logs-otlp-http

Short description of the changes

Implements otlp-http exporter for logs, support web and node. The implementation of Logs has been mentioned in #3442 before, but due to the large amount of code, it was split into SDK and Exporter parts. This is the implementation of the Exporter part.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Run the included unit tests.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@fuaiyi fuaiyi requested a review from a team April 26, 2023 19:21
@fuaiyi fuaiyi changed the title feat(exporter-logs-otlp-http): implements exporter-logs-otlp-http feat(exporter-logs-otlp-http): implements otlp-http exporter for logs Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #3764 (1fc2f76) into main (c6635fa) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

❗ Current head 1fc2f76 differs from pull request most recent head 24d2f52. Consider uploading reports for the commit 24d2f52 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3764      +/-   ##
==========================================
- Coverage   92.96%   92.95%   -0.01%     
==========================================
  Files         295      297       +2     
  Lines        9036     9060      +24     
  Branches     1841     1848       +7     
==========================================
+ Hits         8400     8422      +22     
- Misses        636      638       +2     
Impacted Files Coverage Δ
...ogs-otlp-http/src/platform/node/OTLPLogExporter.ts 83.33% <83.33%> (ø)
...ges/exporter-logs-otlp-http/src/platform/config.ts 100.00% <100.00%> (ø)

@fuaiyi
Copy link
Contributor Author

fuaiyi commented Apr 26, 2023

@dyladan @pichlermarc @martinkuba cc.
I'm so sorry that I've been a bit busy lately and didn't have time to submit this PR. It wasn't until yesterday when I saw that other contributor had already open a draft PR #3755

@dyladan
Copy link
Member

dyladan commented Apr 27, 2023

@fuaiyi is this meant to replace #3755 or is it a competing alternative?

@dyladan
Copy link
Member

dyladan commented Apr 27, 2023

Nevermind I just read the context in the other PR

@fuaiyi
Copy link
Contributor Author

fuaiyi commented Apr 27, 2023

@fuaiyi is this meant to replace #3755 or is it a competing alternative?

@dyladan replace. I have contacted another contributor in #3755, and he/she will also make further contributions based on this PR. (Mainly considering that the development has actually been completed before, so there is no need to repeat it. #3755 also seems to have not been fully developed yet.

@dyladan
Copy link
Member

dyladan commented May 17, 2023

Many failing CI steps

@fuaiyi
Copy link
Contributor Author

fuaiyi commented May 18, 2023

Many failing CI steps

fixed, cc~

@fuaiyi fuaiyi force-pushed the logs-exporter-otlp-http branch from e3db123 to b698789 Compare May 22, 2023 07:06
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 🙂
Just a few docs nits 🙂

experimental/packages/exporter-logs-otlp-http/README.md Outdated Show resolved Hide resolved
experimental/packages/exporter-logs-otlp-http/README.md Outdated Show resolved Hide resolved
@fuaiyi
Copy link
Contributor Author

fuaiyi commented May 25, 2023

@dyladan take a look and see if can merge ?

@pichlermarc
Copy link
Member

Reached out to Dan - Martin & my reviews should be sufficient. 🙂

@pichlermarc pichlermarc merged commit fe82d7b into open-telemetry:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants