Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove unused mkdirp and rimraf dependencies #3737

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Looks like mkdirp and rimraf are both unused.

Short description of the changes

This PR removes all dependencies to rimraf and mkdirp

supersedes #3732
supersedes #3731

Type of change

  • dependencies/internal

How Has This Been Tested?

  • Existing tests

@pichlermarc pichlermarc added dependencies Pull requests that update a dependency file internal Skip Changelog labels Apr 17, 2023
@pichlermarc pichlermarc changed the title deps(otlp-transformer): remove unused mkdirp and rimraf dependencies deps: remove unused mkdirp and rimraf dependencies Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #3737 (0e6f3a6) into main (053acb6) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0e6f3a6 differs from pull request most recent head cda663f. Consider uploading reports for the commit cda663f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3737      +/-   ##
==========================================
+ Coverage   93.44%   93.45%   +0.01%     
==========================================
  Files         290      290              
  Lines        8845     8845              
  Branches     1834     1834              
==========================================
+ Hits         8265     8266       +1     
+ Misses        580      579       -1     

see 1 file with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review April 17, 2023 12:05
@pichlermarc pichlermarc requested a review from a team April 17, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants