fix(exporter-jaeger): lazy require jaeger-client #3728
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
JaegerExporter
currently does not support running in bundled environments, as requiringjaeger-client
loads.thrift
files from the file system. This causes problems in@opentelemetry/sdk-node
as theJaegerExporter
is required even though it is not being used (see #3521).To circumvent this problem, this PR changes the approach of always
require
ingjaeger-client
to do it once the constructor is actually called. Further added documentation to clarify that bundling is not supported with this package.This PR does not add support for running the
JaegerExporter
in a bundled environment.Fixes #3521
Type of change
How Has This Been Tested?
Alternatives I have considered
jaeger-client
and pre-generating JS code from the.thrift
files.JaegerExporter
fromsdk-node
sdk-node
package is deprecated, but I decided against doing this as it would break existingJaegerExporter
users of thesdk-node
package without warning.Checklist: