Merge v1.10.1 changelog/version updates #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(resource): make properties for async resource resolution optional (open-telemetry#3677) * fix(resource): make properties for async resolution optional * fix(changelog): add changelog * fix(resources): add regression test * fix(resources): remove ts-ignore in tests --------- Co-authored-by: Daniel Dyla <[email protected]> * Changelog * Bump patch versions * fix(resources): change fs/promises import to be node 12 compatible (open-telemetry#3681) * fix(resources): change fs/promises import to be node 12 compatible * fix(changelog): add changelog entry. --------- Co-authored-by: Marc Pichler <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3692 +/- ##
==========================================
- Coverage 93.70% 93.68% -0.02%
==========================================
Files 277 277
Lines 8445 8445
Branches 1753 1753
==========================================
- Hits 7913 7912 -1
- Misses 532 533 +1 |
MSNev
approved these changes
Mar 20, 2023
trentm
reviewed
Mar 28, 2023
Comment on lines
-15
to
-22
| * fix(sdk-metrics): merge uncollected delta accumulations [#3667](https://github.com/open-telemetry/opentelemetry-js/pull/3667) @legendecas | ||
| * feat(resources): collect additional process attributes [#3605](https://github.com/open-telemetry/opentelemetry-js/pull/3605) @mwear | ||
|
|
||
| ### :bug: (Bug Fix) | ||
|
|
||
| * fix(sdk-trace-web): make `parseUrl()` respect document.baseURI [#3670](https://github.com/open-telemetry/opentelemetry-js/pull/3670) @domasx2 | ||
| * fix(resource): make properties for async resource resolution optional [#3677](https://github.com/open-telemetry/opentelemetry-js/pull/3677) @pichlermarc | ||
| * fix(resources): change fs/promises import to be node 12 compatible [#3681](https://github.com/open-telemetry/opentelemetry-js/pull/3681) @pichlermarc |
There was a problem hiding this comment.
@dyladan Were these two changelog removals accidental?
There was a problem hiding this comment.
Ah, I see the "change fs/promises import to be node 12 compatible" one was in the 1.10.1 release below. However the "merge uncollected delta accumulations" changelog entry is gone. I'll ask on the 1.11.0 release issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the v1.10.1 backports into main
everything here has already been approved and released in #3682