-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update http example #3651
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3651 +/- ##
==========================================
- Coverage 93.73% 93.72% -0.02%
==========================================
Files 274 274
Lines 8060 8060
Branches 1671 1671
==========================================
- Hits 7555 7554 -1
- Misses 505 506 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for updating this 🙂
If you'd like you could also add the example to lerna.json
as we did with the other already updated examples. This way the OTel dependencies will keep up-to-date as we release new versions. 🙂
Ah, I didn't see that! Makes sense. Looks like @dyladan took care of that for me this time but good to know. |
Which problem is this PR solving?
The
http
example had outdated dependencies, and were still using older functions for getting active spans when newer convenience APIs are available now.Short description of the changes
package.json
startActiveSpan()
andgetActiveSpan()
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: