-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): windows tests are failing #3637
Conversation
9f875c4
to
cdb3502
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3637 +/- ##
==========================================
+ Coverage 93.79% 94.07% +0.27%
==========================================
Files 264 268 +4
Lines 7349 7930 +581
Branches 1491 1645 +154
==========================================
+ Hits 6893 7460 +567
- Misses 456 470 +14
|
Hmm, while this is fixing the out of memory issue the |
@@ -9,7 +9,7 @@ | |||
"prepublishOnly": "npm run compile", | |||
"compile": "tsc --build", | |||
"clean": "tsc --build --clean", | |||
"test": "nyc ts-mocha -p tsconfig.json test/**/*.test.ts", | |||
"test": "cross-env NODE_OPTIONS='--max-old-space-size=8192' nyc ts-mocha -p tsconfig.json test/**/*.test.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is here to fix local (cloned repo) builds, it also fixes the CI test run for unit-test.yml
, but because of other failing tests I've also added line 67 NODE_OPTIONS: --max-old-space-size=8192
to unit-test.yml
.
Only the instrumentation-http package was failing for a local clone build (for me at least).
Restarted windows build and it reports OOM for shim-opentracing too:
|
Looks like #3642 addresses the underlying issue causing the high memory so that might be a better way to go |
Which problem is this PR solving?
This issue is occurring because the underlying v8 engine used by node is consuming more memory on windows, while #3628 is about the
tests
failing on WIndows build, it also fails on a windows machine.Fixes #3628
Short description of the changes
This is a targeted fix for the current project that is failing to build, this could also be applied in the unit-test.yml, but that would not address (fix) for anyone cloning and running tests in the repo on a Windows machine.
For reference the
--max-old-space-size=
is actually a v8 configuration option (not specifically node)nodejs/node#7937
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally on a Windows development machine with the following repo steps (the only way locally I found to repo), the clean is required because lerna was caching the result once a successful build occurred.
And also in the GitHub pipeline