Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused argument #3626

Merged
merged 3 commits into from
Feb 22, 2023
Merged

chore: remove unused argument #3626

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6af3a4d
chore: remove unused argument
SimenB Feb 22, 2023
48652de
Merge branch 'main' into remove-unused-parameter
dyladan Feb 22, 2023
3e1b954
Merge branch 'main' into remove-unused-parameter
dyladan Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions experimental/packages/opentelemetry-instrumentation-http/src/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,12 @@ export class HttpInstrumentation extends InstrumentationBase<Http> {
* Attach event listeners to a client request to end span and add span attributes.
*
* @param request The original request object.
* @param options The arguments to the original function.
* @param span representing the current operation
* @param startTime representing the start time of the request to calculate duration in Metric
* @param metricAttributes metric attributes
*/
private _traceClientRequest(
request: http.ClientRequest,
hostname: string,
span: Span,
startTime: HrTime,
metricAttributes: MetricAttributes
Expand Down Expand Up @@ -687,7 +685,6 @@ export class HttpInstrumentation extends InstrumentationBase<Http> {
context.bind(parentContext, request);
return instrumentation._traceClientRequest(
request,
hostname,
span,
startTime,
metricAttributes
Expand Down