-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(jeager-exporter): deprecate jaeger exporter #3585
chore(jeager-exporter): deprecate jaeger exporter #3585
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3585 +/- ##
==========================================
- Coverage 93.64% 93.63% -0.02%
==========================================
Files 275 275
Lines 8090 8076 -14
Branches 1679 1675 -4
==========================================
- Hits 7576 7562 -14
Misses 514 514
|
I think we should deprecate it and also aim to remove it from the distribution/repo. Do we have a defined deprecation cycle for GAed components? Currently there is a pinned dependency to core and sdk-trace-base which is problematic in case we just stop releasing new versions. Maybe exclude it from lerna project and change these deps to ranges and then stop releasing it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the first step is to add the deprecation warning now.
In July 2023 it makes sense to have one last release with caret dependency and then deprecate it in npm. Do we need to keep it in the codebase after July 2023?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now set the EOL date to |
I think the deprecation warning is enough |
Which problem is this PR solving?
The end of the Jaeger exporter support was announced in the spec (open-telemetry/opentelemetry-specification#2858). From July 2023 onwards, having a Jaeger Exporter will be optional. This PR adds a deprecation notice to the jsdoc of the exporter, as well as to the README.
The intention of this PR is to gather feedback if deprecating the exporter is something that we'd want to do. 🙂
Fixes #2618
Checklist: