-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-trace-base): add dropped attributes and events count on span #3576
Merged
legendecas
merged 36 commits into
open-telemetry:main
from
mohitk05:feat/span-dropped-counts
Mar 8, 2023
Merged
Changes from 33 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
b2c9f40
feat(sdk-trace-base): add dropped attributes and events count on span
mohitk05 55a26b8
feat(sdk-trace-base): sync with main
mohitk05 b3e0307
feat(sdk-trace-base): [revert] sync with main
mohitk05 842143d
Merge branch 'main' into feat/span-dropped-counts
mohitk05 bab88a1
feat(sdk-trace-base): fix tests, make both counts truthy
mohitk05 33378f8
Merge branch 'feat/span-dropped-counts' of github.com:mohitk05/opente…
mohitk05 28666c6
Merge branch 'main' into feat/span-dropped-counts
mohitk05 17213bd
feat(sdk-trace-base): Update dropped counts type to number
mohitk05 81e35f6
Merge branch 'open-telemetry:main' into feat/span-dropped-counts
mohitk05 4eb895c
feat(sdk-trace-base): Merge branch 'feat/span-dropped-counts' of gith…
mohitk05 a8c1454
Merge branch 'main' into feat/span-dropped-counts
mohitk05 dc78fa3
feat(sdk-trace-base): Use exposed counts on ReadableSpan in jaeger an…
mohitk05 08d75e4
feat(sdk-trace-base): Merge branch 'feat/span-dropped-counts' of gith…
mohitk05 4a3105e
Merge branch 'main' into feat/span-dropped-counts
dyladan 411c1cb
feat(sdk-trace-base): WIP - revert tsconfig, add new attribute limits
mohitk05 32300bf
feat(sdk-trace-base): Update attribute truncate method
mohitk05 5439f4e
Merge branch 'main' into feat/span-dropped-counts
dyladan 0365435
Fix bad conflict resolution
dyladan 8a486c7
Remove unused import
dyladan f9d935c
chore: lint
dyladan 036190f
Merge branch 'main' into feat/span-dropped-counts
mohitk05 18d82c6
feat(sdk-trace-base): Remove dropped event attributes logic, add Jaeg…
mohitk05 f674906
feat(sdk-trace-base): Undo formatting in changelog
mohitk05 577b174
fix(changelog): Update experimental changelog
mohitk05 6dadccb
Update packages/opentelemetry-sdk-trace-base/src/Span.ts
mohitk05 1748267
Update packages/opentelemetry-sdk-trace-base/src/Span.ts
mohitk05 cc632ef
Merge branch 'main' into feat/span-dropped-counts
mohitk05 69b407f
fix(sdk-trace-base): Resolve review comments
mohitk05 85b2038
Merge branch 'main' into feat/span-dropped-counts
Flarna f260436
fix(sdk-trace-base): Fix failing tests
mohitk05 1db099c
Merge branch 'main' into feat/span-dropped-counts
mohitk05 0239413
fix(sdk-trace-base): make droppedAttributesCount on event optional
mohitk05 f40a11b
Merge branch 'main' into feat/span-dropped-counts
mohitk05 60bc89f
Merge branch 'main' into feat/span-dropped-counts
Flarna 141172e
Merge branch 'main' into feat/span-dropped-counts
mohitk05 2221770
fix(changelog): Update changelog files
mohitk05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This applies to more than just trace base. I think it's acceptable for the subject to apply to multiple packages.