-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect host id for non-cloud environments #3575
Merged
pichlermarc
merged 5 commits into
open-telemetry:main
from
mwear:host-id-resource-attribute
Mar 1, 2023
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
879829a
feat: add per platform machineId detection
mwear 57e7af8
feat: detect host.id in HostDetector
mwear 0f161f6
chore: add changelog entry
mwear 3b0e865
chore: linting
mwear 38bd2e6
Merge branch 'main' into host-id-resource-attribute
pichlermarc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/opentelemetry-resources/src/platform/node/machine-id/execAsync.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import * as child_process from 'child_process'; | ||
import * as util from 'util'; | ||
|
||
export const execAsync = util.promisify(child_process.exec); |
37 changes: 37 additions & 0 deletions
37
packages/opentelemetry-resources/src/platform/node/machine-id/getMachineId-bsd.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import * as fs from 'fs/promises'; | ||
import { execAsync } from './execAsync'; | ||
import { diag } from '@opentelemetry/api'; | ||
|
||
export async function getMachineId(): Promise<string> { | ||
try { | ||
const result = await fs.readFile('/etc/hostid', { encoding: 'utf8' }); | ||
return result.trim(); | ||
} catch (e) { | ||
diag.debug(`error reading machine id: ${e}`); | ||
} | ||
|
||
try { | ||
const result = await execAsync('kenv -q smbios.system.uuid'); | ||
return result.stdout.trim(); | ||
} catch (e) { | ||
diag.debug(`error reading machine id: ${e}`); | ||
} | ||
|
||
return ''; | ||
} |
41 changes: 41 additions & 0 deletions
41
packages/opentelemetry-resources/src/platform/node/machine-id/getMachineId-darwin.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { execAsync } from './execAsync'; | ||
import { diag } from '@opentelemetry/api'; | ||
|
||
export async function getMachineId(): Promise<string> { | ||
try { | ||
const result = await execAsync('ioreg -rd1 -c "IOPlatformExpertDevice"'); | ||
|
||
const idLine = result.stdout | ||
.split('\n') | ||
.find(line => line.includes('IOPlatformUUID')); | ||
|
||
if (!idLine) { | ||
return ''; | ||
} | ||
|
||
const parts = idLine.split('" = "'); | ||
if (parts.length === 2) { | ||
return parts[1].slice(0, -1); | ||
} | ||
} catch (e) { | ||
diag.debug(`error reading machine id: ${e}`); | ||
} | ||
|
||
return ''; | ||
} |
32 changes: 32 additions & 0 deletions
32
packages/opentelemetry-resources/src/platform/node/machine-id/getMachineId-linux.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
import * as fs from 'fs/promises'; | ||
import { diag } from '@opentelemetry/api'; | ||
|
||
export async function getMachineId(): Promise<string> { | ||
const paths = ['/etc/machine-id', '/var/lib/dbus/machine-id']; | ||
|
||
for (const path of paths) { | ||
try { | ||
const result = await fs.readFile(path, { encoding: 'utf8' }); | ||
return result.trim(); | ||
} catch (e) { | ||
diag.debug(`error reading machine id: ${e}`); | ||
} | ||
} | ||
|
||
return ''; | ||
} |
22 changes: 22 additions & 0 deletions
22
packages/opentelemetry-resources/src/platform/node/machine-id/getMachineId-unsupported.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { diag } from '@opentelemetry/api'; | ||
|
||
export async function getMachineId(): Promise<string> { | ||
diag.debug('could not read machine-id: unsupported platform'); | ||
return ''; | ||
} |
40 changes: 40 additions & 0 deletions
40
packages/opentelemetry-resources/src/platform/node/machine-id/getMachineId-win.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import * as process from 'process'; | ||
import { execAsync } from './execAsync'; | ||
import { diag } from '@opentelemetry/api'; | ||
|
||
export async function getMachineId(): Promise<string> { | ||
const args = | ||
'QUERY HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Cryptography /v MachineGuid'; | ||
let command = '%windir%\\System32\\REG.exe'; | ||
if (process.arch === 'ia32' && 'PROCESSOR_ARCHITEW6432' in process.env) { | ||
command = '%windir%\\sysnative\\cmd.exe /c ' + command; | ||
} | ||
|
||
try { | ||
const result = await execAsync(`${command} ${args}`); | ||
const parts = result.stdout.split('REG_SZ'); | ||
if (parts.length === 2) { | ||
return parts[1].trim(); | ||
} | ||
} catch (e) { | ||
diag.debug(`error reading machine id: ${e}`); | ||
} | ||
|
||
return ''; | ||
} |
37 changes: 37 additions & 0 deletions
37
packages/opentelemetry-resources/src/platform/node/machine-id/getMachineId.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
import * as process from 'process'; | ||
|
||
let getMachineId: () => Promise<string>; | ||
|
||
switch (process.platform) { | ||
case 'darwin': | ||
({ getMachineId } = require('./getMachineId-darwin')); | ||
break; | ||
case 'linux': | ||
({ getMachineId } = require('./getMachineId-linux')); | ||
break; | ||
case 'freebsd': | ||
({ getMachineId } = require('./getMachineId-bsd')); | ||
break; | ||
case 'win32': | ||
({ getMachineId } = require('./getMachineId-win')); | ||
break; | ||
default: | ||
({ getMachineId } = require('./getMachineId-unsupported')); | ||
} | ||
|
||
export { getMachineId }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tagging @hectorhdzg @JacksonWeber for visibility and any comments