Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation): fix web instrumentation span clock drifts #3518

Closed

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jan 3, 2023

Which problem is this PR solving?

Fixes parts of #3355

Short description of the changes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • TODO

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #3518 (603253c) into main (eecb800) will increase coverage by 0.03%.
The diff coverage is 98.63%.

❗ Current head 603253c differs from pull request most recent head 5b49af7. Consider uploading reports for the commit 5b49af7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3518      +/-   ##
==========================================
+ Coverage   93.75%   93.79%   +0.03%     
==========================================
  Files         249      249              
  Lines        7610     7638      +28     
  Branches     1587     1588       +1     
==========================================
+ Hits         7135     7164      +29     
+ Misses        475      474       -1     
Impacted Files Coverage Δ
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.59% <95.83%> (-0.42%) ⬇️
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.68% <100.00%> (+0.10%) ⬆️
packages/opentelemetry-core/src/common/time.ts 98.57% <100.00%> (+3.11%) ⬆️
packages/opentelemetry-sdk-trace-web/src/utils.ts 95.20% <100.00%> (+0.17%) ⬆️

@legendecas legendecas force-pushed the clock/instrumentation branch from 7ad5c9d to 5b49af7 Compare January 3, 2023 10:25
@legendecas
Copy link
Member Author

Closing in favor of #3434.

@legendecas legendecas closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant