Correct NaN String in the Prometheus Exporter #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
approved these changes
Dec 7, 2022
|
@JacksonWeber you need to update failing test case as well |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3477 +/- ##
=======================================
Coverage 93.76% 93.76%
=======================================
Files 248 248
Lines 7567 7567
Branches 1580 1580
=======================================
Hits 7095 7095
Misses 472 472
|
|
CLA needs to be signed before we can land this PR. |
legendecas
approved these changes
Dec 9, 2022
|
Thank you for working on this! A changelog entry at https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/CHANGELOG.md#bug-bug-fix needs to be added. |
…sonWeber/opentelemetry-js into jacksonweber/prometheus-nan # Conflicts: # experimental/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes (issue): #3465
Short description of the changes
Corrects the string used for NaN in the
PrometheusSerializerfrom 'Nan' to 'NaN'.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: