Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: automatically generate tsconfigs #3432

Merged
merged 5 commits into from
Nov 23, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Nov 21, 2022

Which problem is this PR solving?

Fixes #3398

Short description of the changes

  1. Split tsconfig into 3 root entries: default, esnext, esm.
    1. When testing locally, found that when tsconfig targets which are referenced share identical source files, some targets will not output files correctly. So splitting them into different compilation units.
  2. Compile all tsconfig entries when running npm run compile.

Type of change

  • Internal house keeping.

Checklist:

  • Followed the style guidelines of this project

@legendecas legendecas changed the title Tsconfig references chore: automatically generate tsconfigs Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #3432 (1b935f2) into main (ed98c6f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3432      +/-   ##
==========================================
- Coverage   93.29%   93.28%   -0.02%     
==========================================
  Files         247      247              
  Lines        7352     7352              
  Branches     1512     1512              
==========================================
- Hits         6859     6858       -1     
- Misses        493      494       +1     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@legendecas legendecas marked this pull request as ready for review November 21, 2022 08:57
@legendecas legendecas requested a review from a team November 21, 2022 08:57
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. 🙂
Looks like there are some hiccups but after applying the suggestions this works for me locally. 🙂

package.json Outdated Show resolved Hide resolved
scripts/update-ts-configs.js Outdated Show resolved Hide resolved
Co-authored-by: Marc Pichler <[email protected]>
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also works for me locally after @pichlermarc changes (macos). Applied them.

@legendecas legendecas merged commit 897c136 into open-telemetry:main Nov 23, 2022
@legendecas legendecas deleted the tsconfig-references branch November 23, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree shaking tests fail if ESM build not yet completed
4 participants