Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-http): monitor error events with events.errorMonitor #3402

Merged
merged 2 commits into from
Nov 13, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Nov 11, 2022

Which problem is this PR solving?

Related: #225

As support for Node.js versions lower than v12 are dropped, error events can be monitored without side-effects with events.errorMonitor.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Verified Error event listeners counts.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@legendecas legendecas marked this pull request as ready for review November 11, 2022 03:31
@legendecas legendecas requested a review from a team November 11, 2022 03:31
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #3402 (92c38fa) into main (76073ee) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3402      +/-   ##
==========================================
- Coverage   93.33%   93.24%   -0.09%     
==========================================
  Files         246      247       +1     
  Lines        7326     7347      +21     
  Branches     1507     1512       +5     
==========================================
+ Hits         6838     6851      +13     
- Misses        488      496       +8     
Impacted Files Coverage Δ
...ges/opentelemetry-instrumentation-http/src/http.ts 94.78% <100.00%> (+0.01%) ⬆️
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
.../src/platform/browser/export/BatchSpanProcessor.ts 45.00% <0.00%> (ø)
...kages/opentelemetry-sdk-trace-base/karma.worker.js 100.00% <0.00%> (+100.00%) ⬆️

@vmarchaud vmarchaud merged commit b4f04ae into open-telemetry:main Nov 13, 2022
@legendecas legendecas deleted the instrumentation/http-error branch November 14, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants