-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getActiveBaggage API #3385
Merged
vmarchaud
merged 6 commits into
open-telemetry:main
from
cartermp:cartermp/active-baggage
Nov 20, 2022
Merged
Add getActiveBaggage API #3385
vmarchaud
merged 6 commits into
open-telemetry:main
from
cartermp:cartermp/active-baggage
Nov 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
commented
Nov 4, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3385 +/- ##
==========================================
- Coverage 93.29% 93.20% -0.09%
==========================================
Files 247 246 -1
Lines 7348 7332 -16
Branches 1512 1507 -5
==========================================
- Hits 6855 6834 -21
- Misses 493 498 +5
|
legendecas
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
An entry needs to be added to https://github.com/open-telemetry/opentelemetry-js/blob/main/api/CHANGELOG.md.
vmarchaud
approved these changes
Nov 13, 2022
vmarchaud
approved these changes
Nov 20, 2022
vmarchaud
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3354