-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resources): strict OTEL_RESOURCE_ATTRIBUTES decoding #3341
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3341 +/- ##
==========================================
+ Coverage 92.68% 93.53% +0.84%
==========================================
Files 237 244 +7
Lines 6921 7394 +473
Branches 1443 1532 +89
==========================================
+ Hits 6415 6916 +501
+ Misses 506 478 -28
|
223f0ad
to
ad32fb6
Compare
I didn't realize characters outside the baggage-octet range MUST be percent-encoded. Great fix. |
The baggage specification is actually going to remove that wording. The spec will simply state the character range which is allowed and suggest percent encoding as one possible way to stay within the allowed character range. source: I am on the working group which made the decision |
lint failure caused by shields.io. rerunning but it isn't a blocker |
Which problem is this PR solving?
Fixes #3131
Type of change
How Has This Been Tested?
Checklist: