Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracer web #334
Tracer web #334
Changes from 8 commits
d9d152d
ab74943
8cfea09
873a287
9e37fb9
d10fbdd
62965ad
354930d
e8b7503
117c10f
d5129ca
8eca21f
74941c1
a7616f1
62406aa
757458c
2ff8c62
ca873bf
c8c81c1
446c8c7
c44c1a5
a430a4f
a0fd67f
a2db249
41a4d27
28614f2
835b31b
fdc3162
8be9ed7
50ec127
8f6ae2c
104ba4b
b0eb537
04eced8
e90b49f
a57fdc8
5df0726
61fc904
d0579b9
1dfc09f
92d5694
3091a89
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have already excluded
test/index-webpack.ts
in.nycrc
. https://github.com/open-telemetry/opentelemetry-js/blob/master/.nycrc#L11There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I remove it then it doesn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of
opentelemetry-tracer-web
, what do you think aboutopentelemetry-web-tracer
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this name has been already decided in
OpenTelem web draft
I don't have strong opinion on that but personally I would keepopentelemetry-tracer-web
,opentelemetry-tracer-node
,opentelemetry-tracer-basic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayurkale22 so what do you think about it ?, I'm fine for both, but I didn't propose
opentelemetry-tracer-web
although thinking this name to be easier as we can have then the namespace ofopentelemetry-tracer-*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with
opentelemetry-tracer-web
, which means we need to renameopentelemetry-basic-tracer
->opentelemetry-tracer-basic
.