feat: browser support for exporter-trace-otlp-proto #3208
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <!DOCTYPE html> | ||
|
There was a problem hiding this comment. You might want to call this folder |
||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Fetch Plugin Example</title> | ||
| <base href="/"> | ||
|
|
||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| </head> | ||
|
|
||
| <body> | ||
| Example of using Web Tracer with Fetch plugin with console exporter and proto exporter | ||
| <script type="text/javascript" src="fetchProtoExporter.js"></script> | ||
| <br/> | ||
| <button id="button1">Test</button> | ||
|
|
||
| </body> | ||
|
|
||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| const { context, trace } = require("@opentelemetry/api"); | ||
| const { | ||
| ConsoleSpanExporter, | ||
| SimpleSpanProcessor, | ||
| } = require("@opentelemetry/sdk-trace-base"); | ||
| const { WebTracerProvider } = require("@opentelemetry/sdk-trace-web"); | ||
| const { | ||
| FetchInstrumentation, | ||
| } = require("@opentelemetry/instrumentation-fetch"); | ||
| const { ZoneContextManager } = require("@opentelemetry/context-zone"); | ||
| const { B3Propagator } = require("@opentelemetry/propagator-b3"); | ||
| const { registerInstrumentations } = require("@opentelemetry/instrumentation"); | ||
| const { | ||
| OTLPTraceExporter: OTLPTraceExporterProto, | ||
| } = require("@opentelemetry/exporter-trace-otlp-proto/build/src/platform"); | ||
pichlermarc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const provider = new WebTracerProvider(); | ||
|
|
||
| // Note: For production consider using the "BatchSpanProcessor" to reduce the number of requests | ||
| // to your exporter. Using the SimpleSpanProcessor here as it sends the spans immediately to the | ||
| // exporter without delay | ||
| provider.addSpanProcessor(new SimpleSpanProcessor(new ConsoleSpanExporter())); | ||
| provider.addSpanProcessor( | ||
| new SimpleSpanProcessor(new OTLPTraceExporterProto()) | ||
| ); | ||
|
|
||
| // provider.addSpanProcessor( | ||
pichlermarc marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. This commented out code can be removed, I think 🙂 |
||
| // new SimpleSpanProcessor( | ||
| // new OTLPTraceExporterProto({ | ||
| // url: "https://api.honeycomb.io/v1/traces", | ||
| // headers: { | ||
| // }, | ||
| // }) | ||
| // ) | ||
| // ); | ||
|
|
||
| provider.register({ | ||
| contextManager: new ZoneContextManager(), | ||
| propagator: new B3Propagator(), | ||
| }); | ||
|
|
||
| registerInstrumentations({ | ||
| instrumentations: [ | ||
| new FetchInstrumentation({ | ||
| ignoreUrls: [/localhost:8090\/sockjs-node/], | ||
| propagateTraceHeaderCorsUrls: [ | ||
| "https://cors-test.appspot.com/test", | ||
| "https://httpbin.org/get", | ||
| ], | ||
| clearTimingResources: true, | ||
| }), | ||
| ], | ||
| }); | ||
|
|
||
| const webTracerWithZone = provider.getTracer("example-tracer-web"); | ||
|
|
||
| const getData = (url) => | ||
| fetch(url, { | ||
| method: "GET", | ||
| headers: { | ||
| Accept: "application/json", | ||
| "Content-Type": "application/json", | ||
| }, | ||
| }); | ||
|
|
||
| // example of keeping track of context between async operations | ||
| const prepareClickEvent = () => { | ||
| const url = "https://httpbin.org/get"; | ||
|
|
||
| const element = document.getElementById("button1"); | ||
|
|
||
| const onClick = () => { | ||
| const singleSpan = webTracerWithZone.startSpan("files-series-info"); | ||
| context.with(trace.setSpan(context.active(), singleSpan), () => { | ||
| getData(url).then((_data) => { | ||
| trace | ||
| .getSpan(context.active()) | ||
| .addEvent("fetching-single-span-completed"); | ||
| singleSpan.end(); | ||
| }); | ||
| }); | ||
| for (let i = 0, j = 5; i < j; i += 1) { | ||
| const span = webTracerWithZone.startSpan(`files-series-info-${i}`); | ||
| context.with(trace.setSpan(context.active(), span), () => { | ||
| getData(url).then((_data) => { | ||
| trace | ||
| .getSpan(context.active()) | ||
| .addEvent(`fetching-span-${i}-completed`); | ||
| span.end(); | ||
| }); | ||
| }); | ||
| } | ||
| }; | ||
| element.addEventListener("click", onClick); | ||
| }; | ||
|
|
||
| window.addEventListener("load", prepareClickEvent); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,66 +1,64 @@ | ||
| const webpack = require("webpack"); | ||
| const webpackMerge = require("webpack-merge"); | ||
| const path = require("path"); | ||
|
|
||
| const directory = path.resolve(__dirname); | ||
|
|
||
| const common = { | ||
| mode: "development", | ||
| entry: { | ||
| metrics: "examples/metrics/index.js", | ||
| fetch: "examples/fetch/index.js", | ||
| "xml-http-request": "examples/xml-http-request/index.js", | ||
| fetchXhr: "examples/fetchXhr/index.js", | ||
| fetchXhrB3: "examples/fetchXhrB3/index.js", | ||
| fetchProtoExporter: "examples/fetchProtoExporter/index.js", | ||
| zipkin: "examples/zipkin/index.js", | ||
| }, | ||
| output: { | ||
| path: path.resolve(__dirname, "dist"), | ||
| filename: "[name].js", | ||
| sourceMapFilename: "[file].map", | ||
| }, | ||
| target: "web", | ||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.js[x]?$/, | ||
| exclude: /(node_modules)/, | ||
| use: { | ||
| loader: "babel-loader", | ||
| }, | ||
| }, | ||
| { | ||
| test: /\.ts$/, | ||
| exclude: /(node_modules)/, | ||
| use: { | ||
| loader: "ts-loader", | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| resolve: { | ||
| modules: [path.resolve(directory), "node_modules"], | ||
| extensions: [".ts", ".js", ".jsx", ".json"], | ||
| }, | ||
| optimization: { | ||
| minimize: false, | ||
| }, | ||
| }; | ||
|
|
||
| module.exports = webpackMerge.merge(common, { | ||
| devtool: "eval-source-map", | ||
| devServer: { | ||
| static: { | ||
| directory: path.resolve(__dirname, "examples"), | ||
| }, | ||
| compress: true, | ||
| }, | ||
| plugins: [ | ||
| new webpack.DefinePlugin({ | ||
| "process.env.NODE_ENV": JSON.stringify("development"), | ||
| }), | ||
| ], | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /*! | ||
| * Copyright The OpenTelemetry Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| const karmaWebpackConfig = require('../../../karma.webpack'); | ||
| const karmaBaseConfig = require('../../../karma.base'); | ||
|
|
||
| module.exports = (config) => { | ||
| config.set(Object.assign({}, karmaBaseConfig, { | ||
| webpack: karmaWebpackConfig, | ||
| files: ['test/browser/index-webpack.ts'], | ||
| preprocessors: { 'test/browser/index-webpack.ts': ['webpack'] } | ||
| })) | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this file has only formatting changes. If so, can you submit them in a separate PR and revert them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also prefer single quotes over double quotes in the repo, but there is just no eslint rule for
*.jsfiles at the moment. For this reason, and for making this PR easier to review, undoning the formatting changes would be greatly appreciated 🙂