-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api-metrics): clean up exports #3198
Merged
legendecas
merged 16 commits into
open-telemetry:main
from
dynatrace-oss-contrib:chore/cleanup-metrics-api-export
Sep 5, 2022
Merged
chore(api-metrics): clean up exports #3198
legendecas
merged 16 commits into
open-telemetry:main
from
dynatrace-oss-contrib:chore/cleanup-metrics-api-export
Sep 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3198 +/- ##
=======================================
Coverage 93.18% 93.19%
=======================================
Files 195 196 +1
Lines 6472 6494 +22
Branches 1366 1371 +5
=======================================
+ Hits 6031 6052 +21
- Misses 441 442 +1
|
legendecas
reviewed
Aug 24, 2022
legendecas
reviewed
Aug 29, 2022
experimental/packages/opentelemetry-instrumentation/test/common/autoLoader.test.ts
Outdated
Show resolved
Hide resolved
legendecas
approved these changes
Aug 29, 2022
90f311e
to
c50eca6
Compare
Sorry for the force-push, something went wrong when I tried to merge main into my branch. Just removed the last commit and replaced it with a merge commit. |
dyladan
approved these changes
Aug 31, 2022
legendecas
approved these changes
Aug 31, 2022
experimental/packages/opentelemetry-api-metrics/src/NoopMeter.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
@opentelemetry/api-metrics
exports some classes and constants that are intended for internal use. In an effort to reduce the API surface before declaring metrics GA, this PR replaces the existing wildcard exports with explicit exports.Related: #3158
Short description of the changes
Replaces the existing wildcard exports with explicit exports and removes export for:
NoopMeter
NoopMetric
NoopCounterMetric
NoopUpDownCounterMetric
NoopHistogramMetric
NoopObservableMetric
NoopObservableCounterMetric
NoopObservableGaugeMetric
NoopObservableUpDownCounterMetric
NOOP_COUNTER_METRIC
NOOP_HISTOGRAM_METRIC
NOOP_UP_DOWN_COUNTER_METRIC
NOOP_OBSERVABLE_COUNTER_METRIC
NOOP_OBSERVABLE_GAUGE_METRIC
NOOP_OBSERVABLE_UP_DOWN_COUNTER_METRIC
NoopMeterProvider
NOOP_METER_PROVIDER
Type of change
How Has This Been Tested?
Checklist: