-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update trace-web
example and rename it to opentelemetry-web
#3145
Merged
legendecas
merged 8 commits into
open-telemetry:main
from
dynatrace-oss-contrib:chore/update-trace-web
Aug 9, 2022
Merged
chore: update trace-web
example and rename it to opentelemetry-web
#3145
legendecas
merged 8 commits into
open-telemetry:main
from
dynatrace-oss-contrib:chore/update-trace-web
Aug 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3145 +/- ##
=======================================
Coverage 93.21% 93.21%
=======================================
Files 196 196
Lines 6414 6414
Branches 1350 1350
=======================================
Hits 5979 5979
Misses 435 435 |
vmarchaud
reviewed
Aug 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm apart from nits
dyladan
reviewed
Aug 8, 2022
dyladan
approved these changes
Aug 9, 2022
legendecas
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Previously, some of the examples in
trace-web
were not working, and themetrics
packages were outdated, and some buttons were not triggering the creation of a trace.This PR:
trace-web
example toopentelemetry-web
, since the examples also include metrics.fetchXhr
andfetchXhrB3
examples.Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
by replacingimport
withrequire
npm
script to run it.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: