Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQL schema attributes #3042

Conversation

KeisukeYamashita
Copy link

WHAT

I've added schema attributes for which was merged by open-telemetry/opentelemetry-specification#2456 to help GraphQL OpenTelemetry uses to specify the attributes of there spans.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added: No unit tests as for not
  • Documentation has been updated: Not updates needed

@KeisukeYamashita KeisukeYamashita requested a review from a team June 16, 2022 12:51
@vmarchaud
Copy link
Member

I believe semantics convention should be updated automatically using with scripts/semconv/generate.sh see https://github.com/open-telemetry/opentelemetry-js/pull/2456/files#diff-c14958cf58b9b6efdaef7f306dff31b8d1915d5832227ecbe1a35d6e95eb34ec

@KeisukeYamashita
Copy link
Author

I believe semantics convention should be updated automatically using with scripts/semconv/generate.sh see https://github.com/open-telemetry/opentelemetry-js/pull/2456/files#diff-c14958cf58b9b6efdaef7f306dff31b8d1915d5832227ecbe1a35d6e95eb34ec

Oh, I see, thank you for pointing it out! Will close this!

@KeisukeYamashita KeisukeYamashita deleted the add-graphql-semantic-conventions-schema-attributes branch June 17, 2022 09:10
@vmarchaud
Copy link
Member

@KeisukeYamashita Feel free to re-open a PR that bump the script though !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants