feat: record exceptions in http instrumentation #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
luismiramirez
force-pushed
the
record-http-errors-as-events
branch
from
a1a8945 to
63c0929
Compare
Codecov Report
@@ Coverage Diff @@
## main #3008 +/- ##
==========================================
- Coverage 92.63% 91.24% -1.40%
==========================================
Files 187 68 -119
Lines 6166 1850 -4316
Branches 1301 392 -909
==========================================
- Hits 5712 1688 -4024
+ Misses 454 162 -292
|
blumamir
approved these changes
May 31, 2022
There was a problem hiding this comment.
LGTM
Thanks for the contribution
Interesting OTEP regarding the future of SpanEvents: https://github.com/open-telemetry/oteps/pull/202/files
experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-enable.test.ts
Show resolved
Hide resolved
luismiramirez
force-pushed
the
record-http-errors-as-events
branch
from
63c0929 to
1248bb6
Compare
dyladan
approved these changes
Jun 1, 2022
experimental/packages/opentelemetry-instrumentation-http/test/utils/assertSpan.ts
Show resolved
Hide resolved
luismiramirez
force-pushed
the
record-http-errors-as-events
branch
from
1248bb6 to
b6d57fc
Compare
dyladan
approved these changes
Jun 1, 2022
luismiramirez
force-pushed
the
record-http-errors-as-events
branch
from
b6d57fc to
03cabe4
Compare
legendecas
approved these changes
Jun 6, 2022
| assert.strictEqual(span.events[0].name, 'exception'); | ||
|
|
||
| const eventAttributes = span.events[0].attributes as Object; | ||
| assert.deepEqual( |
There was a problem hiding this comment.
Strict version of assert.deepEqual is preferred:
Suggested change
| assert.deepEqual( | |
| assert.deepStrictEqual( |
| assert.strictEqual(span.events.length, 1); | ||
| assert.strictEqual(span.events[0].name, 'exception'); | ||
|
|
||
| const eventAttributes = span.events[0].attributes as Object; |
There was a problem hiding this comment.
I'd suggest asserting the eventAttributes to be non-nullish rather than casting it as an object -- the casting has no runtime-effect, we'll get a TypeError below if it is actually an undefined.
Suggested change
| const eventAttributes = span.events[0].attributes as Object; | |
| const eventAttributes = span.events[0].attributes; | |
| assert.ok(eventAttributes != null); |
luismiramirez
force-pushed
the
record-http-errors-as-events
branch
3 times, most recently
from
074c0a3 to
5f6880e
Compare
luismiramirez
force-pushed
the
record-http-errors-as-events
branch
from
5f6880e to
279dec9
Compare
vmarchaud
approved these changes
Jun 12, 2022
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When an error is captured, it is now recorded as an event using recordException().
Short description of the changes
Added the
recordExceptioncall right after the status setup insetSpanWithError().Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated the helper that compares spans so it supports errors being passed and checks if they've been recorded.
Checklist: