Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pichlermarc to approvers #2960

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 10, 2022

Marc has done exceptional work on OTel JS and has been very helpful during the push to release metrics.

@dyladan dyladan requested a review from a team May 10, 2022 17:19
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #2960 (ccf012c) into main (1ee1b28) will increase coverage by 1.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2960      +/-   ##
==========================================
+ Coverage   91.56%   92.78%   +1.22%     
==========================================
  Files         176      183       +7     
  Lines        5439     5921     +482     
  Branches     1169     1257      +88     
==========================================
+ Hits         4980     5494     +514     
+ Misses        459      427      -32     
Impacted Files Coverage Δ
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.63% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.53% <0.00%> (ø)
...lemetry-resources/src/detectors/ProcessDetector.ts 100.00% <0.00%> (+4.54%) ⬆️
packages/opentelemetry-sdk-trace-web/src/utils.ts 95.00% <0.00%> (+29.37%) ⬆️
...lemetry-resources/src/detectors/BrowserDetector.ts 100.00% <0.00%> (+46.66%) ⬆️

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 🎉

@dyladan dyladan merged commit 4c99541 into open-telemetry:main May 11, 2022
@dyladan dyladan deleted the marc-approver branch May 11, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants