Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused InstrumentationConfig#path #2944

Merged
merged 2 commits into from
May 4, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented May 2, 2022

Which problem is this PR solving?

Short description of the changes

Removed the unused field InstrumentationConfig#path as it seems it's not used anywhere. The comment there is also outdated so can't tell if it was ever used.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

CI

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Flarna Flarna requested a review from a team May 2, 2022 07:09
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #2944 (5aa6f8b) into main (ddb0775) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2944   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         185      185           
  Lines        6089     6089           
  Branches     1304     1304           
=======================================
  Hits         5661     5661           
  Misses        428      428           

@Flarna
Copy link
Member Author

Flarna commented May 2, 2022

Actually I'm not sure if changes like this in experimental modules should be marked as breaking or housekeeping.

@blumamir
Copy link
Member

blumamir commented May 2, 2022

Actually I'm not sure if changes like this in experimental modules should be marked as breaking or housekeeping.

I think it's ok to mark it as chore in this case

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an upgrade guideline https://github.com/open-telemetry/opentelemetry-js#upgrade-guidelines that describes the (possible) breaking changes with experimental versions. Maybe we can add an entry to it. Either way, this is lgtm.

@dyladan dyladan merged commit 65aeff0 into open-telemetry:main May 4, 2022
@Flarna Flarna deleted the rm-instr-path branch May 4, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants