Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-node): add no-op logger to fix failing tests. #2940

Closed

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

#2926 introduced warn logs in the @opentelemetry/instrumentation package. The current tests in @opentelemetry/sdk-node are failing as they did not add a warn logger. This PR adds all required loggers so that warn can be called safely.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Existing tests run in CI

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2940 (d427799) into main (60a17ee) will decrease coverage by 16.34%.
The diff coverage is n/a.

❗ Current head d427799 differs from pull request most recent head 8e44c10. Consider uploading reports for the commit 8e44c10 to get more accurate results

@@             Coverage Diff             @@
##             main    #2940       +/-   ##
===========================================
- Coverage   92.39%   76.05%   -16.35%     
===========================================
  Files          69        6       -63     
  Lines        1999      238     -1761     
  Branches      437       53      -384     
===========================================
- Hits         1847      181     -1666     
+ Misses        152       57       -95     
Impacted Files Coverage Δ
packages/opentelemetry-sdk-trace-web/src/utils.ts 65.62% <0.00%> (-29.38%) ⬇️
...ges/opentelemetry-resources/src/detectors/index.ts
...ages/opentelemetry-core/src/internal/validators.ts
...entelemetry-resources/src/detectors/EnvDetector.ts
packages/opentelemetry-core/src/utils/sampling.ts
...ackages/opentelemetry-core/src/trace/TraceState.ts
...lemetry-resources/src/detectors/BrowserDetector.ts
...metrics-otlp-http/src/OTLPMetricExporterOptions.ts
packages/opentelemetry-core/src/utils/promise.ts
...ckages/opentelemetry-core/src/baggage/constants.ts
... and 54 more

@pichlermarc
Copy link
Member Author

This does not fix it after all.
Sorry about that.

@pichlermarc pichlermarc deleted the fix-main-build branch July 20, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant