Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement OSDetector #2927

Merged
merged 6 commits into from
Apr 30, 2022
Merged

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Apr 25, 2022

Which problem is this PR solving?

There's currently no detector for os.* resource attributes.
Related: #2921

Short description of the changes

Added a new detector for detecting OS attributes:

  • os.type which is the only required attribute and
  • os.version.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Added unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

Related: open-telemetry/opentelemetry-specification#2509

@rauno56 rauno56 requested a review from a team April 25, 2022 10:52
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2927 (bf8fd83) into main (df77c62) will decrease coverage by 0.71%.
The diff coverage is 87.50%.

❗ Current head bf8fd83 differs from pull request most recent head 7b700f0. Consider uploading reports for the commit 7b700f0 to get more accurate results

@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
- Coverage   92.50%   91.79%   -0.72%     
==========================================
  Files         171      178       +7     
  Lines        5353     5607     +254     
  Branches     1160     1216      +56     
==========================================
+ Hits         4952     5147     +195     
- Misses        401      460      +59     
Impacted Files Coverage Δ
...pentelemetry-resources/src/detectors/OSDetector.ts 86.66% <86.66%> (ø)
...ges/opentelemetry-resources/src/detectors/index.ts 100.00% <100.00%> (ø)
...telemetry-sdk-trace-web/src/StackContextManager.ts 94.28% <0.00%> (ø)
...-sdk-trace-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
...entelemetry-sdk-trace-web/src/WebTracerProvider.ts 100.00% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/types.ts 100.00% <0.00%> (ø)
...ckages/opentelemetry-sdk-trace-web/karma.worker.js 100.00% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/utils.ts 65.62% <0.00%> (ø)

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work again

@vmarchaud vmarchaud merged commit ddb0775 into open-telemetry:main Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants