-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement OSDetector #2927
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauno56
force-pushed
the
feat/os-detector
branch
from
April 25, 2022 10:53
e272cc6
to
056c660
Compare
Codecov Report
@@ Coverage Diff @@
## main #2927 +/- ##
==========================================
- Coverage 92.50% 91.79% -0.72%
==========================================
Files 171 178 +7
Lines 5353 5607 +254
Branches 1160 1216 +56
==========================================
+ Hits 4952 5147 +195
- Misses 401 460 +59
|
blumamir
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work again
legendecas
approved these changes
Apr 26, 2022
vmarchaud
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
There's currently no detector for
os.*
resource attributes.Related: #2921
Short description of the changes
Added a new detector for detecting OS attributes:
os.type
which is the only required attribute andos.version
.Type of change
How Has This Been Tested?
Checklist:
Related: open-telemetry/opentelemetry-specification#2509