Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage paths #2913

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix code coverage paths #2913

merged 1 commit into from
Apr 20, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 20, 2022

Code coverage paths were pointing to the experimental/tsconfig.json file which no longer exists. They should use the base tsconfig.json as the project root. This is causing some issues with our coverage script detecting bad coverage changes and not being able to locate files properly.

@dyladan dyladan requested a review from a team April 20, 2022 15:15
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #2913 (5ef1177) into main (96465c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2913   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files         187      187           
  Lines        6145     6145           
  Branches     1308     1308           
=======================================
  Hits         5760     5760           
  Misses        385      385           
Impacted Files Coverage Δ
...-otlp-http/src/platform/node/OTLPMetricExporter.ts
...s/exporter-trace-otlp-http/src/OTLPExporterBase.ts
...y-sdk-metrics-base/src/state/AsyncMetricStorage.ts
...orter-metrics-otlp-proto/src/OTLPMetricExporter.ts
.../opentelemetry-api-metrics/src/api/global-utils.ts
packages/exporter-trace-otlp-proto/src/util.ts
...entelemetry-sdk-metrics-base/src/view/Predicate.ts
packages/exporter-trace-otlp-proto/src/types.ts
...mentation-xml-http-request/src/enums/EventNames.ts
...metry-sdk-metrics-base/src/aggregator/Histogram.ts
... and 202 more

@dyladan dyladan merged commit 75cbf5d into open-telemetry:main Apr 20, 2022
@dyladan dyladan deleted the codecov-paths branch April 20, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants