-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add prepublishOnly to ensure a full build #2844
Conversation
The test is failing. It seems like the gcp-detector is not behaving in an expected way... |
Well, it seems the problem is related to @opentelemetry/api version mismatch: @opentelemetry/sdk-node uses ~1.0.3, whilst @opentelemetry/resource-detector-gcp uses v1.1.0 (^1.0.2) |
I think we might consider moving the sdk node to the contrib since all detectors live there |
86f897d
to
4c81b00
Compare
Edit: well, no need to do so. We have only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the main difference between compile
and publishOnly
script?
The I'd wait for @dyladan 's opinion on this since he is the one who performs the releases. |
Isn't it |
@Flarna thank you for pointing that out! That was a silly mistake I've made :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. We'll have to cut a 1.1.1 release to fix the release ASAP
I'm working locally on a branch to automate the releases as I don't want to do it forever |
Which problem is this PR solving?
Fixes: #2843
Add npm script
prepublishOnly
to run a full build before publishing.prepare
may be a good alternative but it also runs onnpm install
-- it may slow down the install step.These build variants have already been tested in our GitHub Action suites.
Refs: https://docs.npmjs.com/cli/v8/using-npm/scripts#life-cycle-operation-order
Short description of the changes
@opentelemetry/api
of@opentelemetry/sdk-node
to~1.1.0
.Type of change
Checklist: