fix(opentelemtry-core): fix header extraction #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
weyert
reviewed
Mar 17, 2022
packages/opentelemetry-core/src/baggage/propagation/W3CBaggagePropagator.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2832 +/- ##
=======================================
Coverage 93.46% 93.47%
=======================================
Files 163 163
Lines 5543 5544 +1
Branches 1167 1168 +1
=======================================
+ Hits 5181 5182 +1
Misses 362 362
|
dyladan
approved these changes
Mar 17, 2022
packages/opentelemetry-core/src/baggage/propagation/W3CBaggagePropagator.ts
Outdated
Show resolved
Hide resolved
dyladan
approved these changes
Mar 17, 2022
packages/opentelemetry-core/src/baggage/propagation/W3CBaggagePropagator.ts
Outdated
Show resolved
Hide resolved
|
LGTM but need one more 👍 from an @open-telemetry/javascript-approvers before merge. |
legendecas
reviewed
Mar 17, 2022
packages/opentelemetry-core/src/baggage/propagation/W3CBaggagePropagator.ts
Outdated
Show resolved
Hide resolved
legendecas
reviewed
Mar 17, 2022
Co-authored-by: legendecas <[email protected]>
legendecas
approved these changes
Mar 17, 2022
vmarchaud
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Solves the problem of extracting the baggage header when it is set inside an array.
Fixes #2831
Checklist: