Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup removed documentation for missing benchmarks #2830

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Cleanup removed documentation for missing benchmarks #2830

merged 1 commit into from
Mar 14, 2022

Conversation

dmathieu
Copy link
Member

Which problem is this PR solving?

This resolved a bit of confusing documentation, stating that benchmarks need to be checked, when those don't exist anymore.

See:

Short description of the changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This is tested through the existing test suite.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@dmathieu dmathieu requested a review from a team March 14, 2022 08:28
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #2830 (406f0be) into main (c6dab2a) will not change coverage.
The diff coverage is n/a.

❗ Current head 406f0be differs from pull request most recent head 07816b7. Consider uploading reports for the commit 07816b7 to get more accurate results

@@           Coverage Diff           @@
##             main    #2830   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         163      163           
  Lines        5543     5543           
  Branches     1167     1167           
=======================================
  Hits         5181     5181           
  Misses        362      362           

@dyladan
Copy link
Member

dyladan commented Mar 14, 2022

Thanks for cleaning this up

@dyladan dyladan added the document Documentation-related label Mar 14, 2022
@dyladan dyladan changed the title Cleanup removed benchmarks Cleanup removed documentation for missing benchmarks Mar 14, 2022
@dyladan dyladan merged commit 4ca2d89 into open-telemetry:main Mar 14, 2022
@dmathieu dmathieu deleted the cleanup-benchmarks branch March 14, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants