-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(baggage): include baggage metadata when propagating baggage entries #2766
Conversation
|
@chrskrchr You'll need to sign the CLA so we can accept the PR |
Codecov Report
@@ Coverage Diff @@
## main #2766 +/- ##
==========================================
- Coverage 93.29% 93.28% -0.02%
==========================================
Files 159 159
Lines 5445 5448 +3
Branches 1143 1144 +1
==========================================
+ Hits 5080 5082 +2
- Misses 365 366 +1
|
Yep! Working on that with my organization now since I'm technically a "corporate contributor". I'll move this PR out of draft mode as soon as I have that sorted. |
@vmarchaud - my CLA has been approved and this PR is ready for review. I see you added the |
I believe its based on the PR tag, but yeah i think its preferable since we should have propagated since in the first place |
Thank you for the work! |
Which problem is this PR solving?
Partially fixes #2740
Short description of the changes
As part of the changes to address #2740, the
W3CBaggagePropagator
needs to be updated to propagate baggage entry metadata. It was previously parsing the metadata on baggage extraction from the inbound request but not including it on propagation.Type of change
This PR might also be considered a "bug fix" since it's adding functionality that was expected to already be in place.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: