Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync webpack version used #2758

Merged
merged 5 commits into from
Feb 9, 2022
Merged

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 3, 2022

Which problem is this PR solving?

Refs: #2755 (comment)

Short description of the changes

Use the same webpack version used to avoid npm install to fail because of peer dependencies can't be resolved.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

local

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

Use the same webpack version used to avoid npm install to fail because of peer dependencies
can't be resolved.
@Flarna Flarna requested a review from a team February 3, 2022 08:15
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #2758 (0e8d845) into main (1dd8a89) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2758   +/-   ##
=======================================
  Coverage   93.28%   93.28%           
=======================================
  Files         159      159           
  Lines        5448     5448           
  Branches     1144     1144           
=======================================
  Hits         5082     5082           
  Misses        366      366           

tsconfig.json Outdated Show resolved Hide resolved
@Flarna Flarna merged commit 4fa3270 into open-telemetry:main Feb 9, 2022
@Flarna Flarna deleted the sync-webpack branch February 9, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants