-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-metrics): remove observable types #2687
Merged
vmarchaud
merged 5 commits into
open-telemetry:main
from
legendecas:metrics-ff/observables
Dec 28, 2021
Merged
feat(api-metrics): remove observable types #2687
vmarchaud
merged 5 commits into
open-telemetry:main
from
legendecas:metrics-ff/observables
Dec 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Codecov Report
@@ Coverage Diff @@
## main #2687 +/- ##
==========================================
+ Coverage 92.52% 92.57% +0.04%
==========================================
Files 151 151
Lines 5283 5276 -7
Branches 1116 1116
==========================================
- Hits 4888 4884 -4
+ Misses 395 392 -3
|
srikanthccv
approved these changes
Dec 23, 2021
dyladan
reviewed
Dec 23, 2021
dyladan
approved these changes
Dec 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the name if you are. We can change it in a follow-up if we need
vmarchaud
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Removes the redundant type definition of observables, since we didn't have any API for a single observable instance yet.
Fixes #2550
Fixes #2551
Fixes #2553
Short description of the changes
Type of change
Checklist: