fix: span attribute count and value limits (#2671) #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #2678 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 155 155
Lines 5368 5371 +3
Branches 1131 1131
=======================================
+ Hits 4994 4997 +3
Misses 374 374
|
rauno56
approved these changes
Jan 5, 2022
dyladan
approved these changes
Jan 5, 2022
blumamir
approved these changes
Jan 7, 2022
vmarchaud
approved these changes
Jan 8, 2022
|
@Bataran it's almost there 🚀. Would you please update the PR since CI is complaining of code styles? Thanks! |
legendecas
approved these changes
Jan 12, 2022
rauno56
added a commit
to rauno56/opentelemetry-js
that referenced
this pull request
Jan 14, 2022
…n-telemetry#2678) Co-authored-by: Rauno Viskus <[email protected]> Co-authored-by: Daniel Dyla <[email protected]> Co-authored-by: Valentin Marchaud <[email protected]> Co-authored-by: legendecas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In case where span attribute count limit (OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT) is explicitly set to its default value (128) and general attribute count limit (OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT) is set then the general limit was used. By the specs this is wrong and the model specific limit should be used instead.
Fixes #2671
Short description of the changes
There is a new Utility function
reconfigureLimits(config: TracerConfig)which must be called before setting any default values to the config provided by a user. The function checks (based on the config provided by the user) if the model specific limits should be assigned or not.Type of change
How Has This Been Tested?