Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update and fix tracer-web examples #2661

Merged
merged 3 commits into from
Dec 15, 2021
Merged

chore: update and fix tracer-web examples #2661

merged 3 commits into from
Dec 15, 2021

Conversation

MSNev
Copy link
Contributor

@MSNev MSNev commented Dec 9, 2021

fix: Lint issues

Updating to package versions

  • webpack to v5
  • sdk-trace-xxx to v1.0.1
  • instrumentation to v0.27.0
  • exporters to v0.27.0

And adds a few additional examples and execution modes to help identify how to use and the resulting bundles sizes based on different configurations

@MSNev MSNev requested a review from a team December 9, 2021 18:12
@codecov
Copy link

codecov bot commented Dec 9, 2021 •
edited
Loading

Codecov Report

Merging #2661 (e02b4a8) into main (f59c5b2) will not change coverage.
The diff coverage is n/a.

❗ Current head e02b4a8 differs from pull request most recent head 3205e9b. Consider uploading reports for the commit 3205e9b to get more accurate results

@@           Coverage Diff           @@
##             main    #2661   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         131      131           
  Lines        4923     4923           
  Branches     1078     1078           
=======================================
  Hits         4593     4593           
  Misses        330      330

@MSNev MSNev mentioned this pull request Dec 9, 2021
Closed
@svetlanabrennan svetlanabrennan mentioned this pull request Dec 13, 2021
Closed
8 tasks
@MSNev MSNev force-pushed the MSNev/TraceWebExamples branch from 92f7cd6 to 72e3c06 Compare December 14, 2021 22:37
@MSNev MSNev force-pushed the MSNev/TraceWebExamples branch from 72e3c06 to 3205e9b Compare December 14, 2021 22:40
@MSNev
Copy link
Contributor Author

MSNev commented Dec 14, 2021 •
edited
Loading

The last push was to merged main to my origin/main branch, rebase this PR branch to my updated main

@dyladan dyladan merged commit 10cd916 into open-telemetry:main Dec 15, 2021
@MSNev MSNev deleted the MSNev/TraceWebExamples branch December 16, 2021 00:30
@dyladan dyladan added internal document Documentation-related and removed internal labels Jan 31, 2022
@dyladan dyladan mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyladan dyladan dyladan left review comments

@svetlanabrennan svetlanabrennan svetlanabrennan approved these changes

@Flarna Flarna Flarna approved these changes

@legendecas legendecas legendecas approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

Assignees
No one assigned
Labels
document Documentation-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MSNev @dyladan @vmarchaud @legendecas @Flarna @svetlanabrennan