Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the compilation for typescript 4.4 #2623

Merged
merged 2 commits into from
Nov 15, 2021
Merged

chore: fix the compilation for typescript 4.4 #2623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
273d5fc
chore: fix the compilation for typescript 4.4
dyladan Nov 15, 2021
bfd6665
chore: use official type for sendfunction
dyladan Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-instrumentation-xml-http-request/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export type OpenFunction = (
/**
* method "send" from XMLHttpRequest
*/
export type SendFunction = (body?: SendBody) => void;
export type SendFunction = typeof XMLHttpRequest.prototype.send;

export type SendBody =
| string
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"sourceMap": true,
"strict": true,
"strictNullChecks": true,
"target": "es2017"
"target": "es2017",
"useUnknownInCatchVariables": false
},
"exclude": [
"node_modules"
Expand Down