Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WIP metrics SDK #2601

Merged
merged 15 commits into from
Nov 15, 2021
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 4, 2021

This is the start of a ground-up rewrite of the metrics SDK. Even if we decide not to move forward with #2598 I think it makes sense to rethink the SDK from the beginning.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #2601 (f2d79aa) into main (7d67bf3) will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2601      +/-   ##
==========================================
+ Coverage   92.87%   93.26%   +0.38%     
==========================================
  Files          98      115      +17     
  Lines        3662     4645     +983     
  Branches      831     1036     +205     
==========================================
+ Hits         3401     4332     +931     
- Misses        261      313      +52     
Impacted Files Coverage Δ
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
...telemetry-sdk-trace-web/src/StackContextManager.ts 94.28% <0.00%> (ø)
...-sdk-trace-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
...opentelemetry-exporter-trace-otlp-http/src/util.ts 100.00% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.98% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/types.ts 100.00% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.58% <0.00%> (ø)
...entelemetry-sdk-trace-web/src/WebTracerProvider.ts 100.00% <0.00%> (ø)
...exporter-metrics-otlp-http/src/transformMetrics.ts 95.65% <0.00%> (ø)
... and 7 more

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for a new wip package so that we can move forward at a fast pace.

Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this PR is not meant to be complete, so feel to address some of the comments in later PRs if that's easier

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when #2601 (comment) is resolve

@dyladan
Copy link
Member Author

dyladan commented Nov 12, 2021

/easycla

Copy link
Member

@pirgeo pirgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very optional, but I think having the links to the respective spec pages is great. Just adding these here for completeness, we could however always add them later (or remove them if we don't want them).

@dyladan dyladan merged commit 6b77b67 into open-telemetry:main Nov 15, 2021
@dyladan dyladan deleted the wip-metrics-sdk branch November 15, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants