Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links in the Readme #2503

Closed
wants to merge 2 commits into from

Conversation

MoritzGruber
Copy link

In the Readme links are broken because stuff has been moved to a new experimental folder and the readme is outdated

Which problem is this PR solving?

  • borken links in readme

In the Readme links are broken because stuff has been moved to a new experimental folder and the readme is outdated
@MoritzGruber MoritzGruber requested a review from a team September 28, 2021 16:43
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 28, 2021

CLA Not Signed

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, you'll need to CLA so we can accept the contribution though

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #2503 (3f3678e) into main (df12218) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2503      +/-   ##
==========================================
- Coverage   93.07%   93.05%   -0.02%     
==========================================
  Files         139      139              
  Lines        5172     5172              
  Branches     1110     1110              
==========================================
- Hits         4814     4813       -1     
- Misses        358      359       +1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@rauno56 rauno56 changed the title Fixes broken links in the Readme docs: fix broken links in the Readme Oct 13, 2021
@rauno56
Copy link
Member

rauno56 commented Oct 14, 2021

Ping, @MoritzGruber, about the CLA.

@obecny
Copy link
Member

obecny commented Oct 15, 2021

@MoritzGruber we can't merge it until you sign the CLA

@dyladan
Copy link
Member

dyladan commented Nov 4, 2021

With no CLA i'm closing this in favor of #2600

@dyladan dyladan closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants