-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove setting http.route in http span attributes #2494
fix: remove setting http.route in http span attributes #2494
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2494 +/- ##
==========================================
- Coverage 93.20% 93.20% -0.01%
==========================================
Files 137 137
Lines 5017 5016 -1
Branches 1060 1059 -1
==========================================
- Hits 4676 4675 -1
Misses 341 341
|
@mustafain117 you'll need to rebase the PR so we can merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please fix the conflicts and this can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Which problem is this PR solving?
Short description of the changes
http.route
attribute is a duplicated field (withhttp.target
attribute). This PR removes setting ofhttp.route
attribute for http spans